Fix flaky Overlay tests (hopefully) #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...Initial build failed due to yet another (unrelated) flaky test. The irony. Retriggering. |
adidahiya
approved these changes
Dec 19, 2017
There was a problem hiding this comment.
this is ugly but I guess it's not much worse than the current code.
can we try another idea? monkey-patch window.requestAnimationFrame (or global or root or whatever) in the test environment to invoke a specified callback which we can listen for so that we know exactly when it's called. also google around for how other people test this kind of behavior?
|
@adidahiya we can try that in a follow-up, yes. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nested
setTimeouts instead of an arbitrary short delay for onesetTimeout. Goal is to delay the code execution until the end of the next frame, not just to the end of the current frame (which may in some instances cause code to invoke before focus has changed /requestAnimationFramehas executed).