Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yesterday and Today shortcuts when allowSingleDayRange enabled #2025

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

rimig
Copy link
Contributor

@rimig rimig commented Jan 23, 2018

Checklist

Changes proposed in this pull request:

Adding a "Today" and "Yesterday" shortcut to the date range selector. These only show up when allowSingleDayRange is enabled (since it wouldn't really work otherwise).

Screenshot

image

@giladgray
Copy link
Contributor

@rimig your circle build does not seem to be running. re-trigger it please?

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nicely done, let's just get that circle building!

@rimig
Copy link
Contributor Author

rimig commented Jan 24, 2018

Add Yesterday and Today shortcuts when allowSingleDayRange enabled

Preview: documentation | landing | table

@giladgray giladgray merged commit cdd306d into palantir:develop Jan 24, 2018
@giladgray
Copy link
Contributor

🤔 just merged this to develop so it'll come out with 2.0, not with 1.x patches. is that ok @rimig?

@rimig
Copy link
Contributor Author

rimig commented Jan 25, 2018

Made a 1.x version: #2039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants