Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLInputProps without ref or key #2034

Merged
merged 4 commits into from
Jan 25, 2018
Merged

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jan 24, 2018

Fixes #943

Changes proposed in this pull request:

  • HTMLInputProps alias uses InputHTMLAttributes instead of HTMLProps (does not include ref or key)
  • remove const { ref, ...htmlInputProps } = inputProps workaround!!
  • add TagInput inputRef prop because inputProps does not expose it anymore.

@blueprint-bot
Copy link

HTMLInputProps doc

Preview: documentation | landing | table

@giladgray
Copy link
Contributor Author

question:
Components that compose InputGroup and accept inputProps?: HTMLInputProps & IInputGroupProps* expose inputRef to access the <input> element, but as it stands currently they do not provide a method to access the InputGroup component class instance. Such components could safely support ref: (ref: InputGroup) => void because it's all in a nested object, but should they?

* - most of the select components and Date[Range]Input do this.

@adidahiya
Copy link
Contributor

Such components could safely support ref: (ref: InputGroup) => void because it's all in a nested object, but should they?

no, we don't need it yet

@giladgray
Copy link
Contributor Author

agreed that we don't need a way to ref the InputGroup -- ref'ing the <input> is the useful one.

@giladgray giladgray merged commit 6b32365 into develop Jan 25, 2018
@giladgray giladgray deleted the gg/html-input-attributes branch January 25, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants