Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all component display names to "Blueprint2.X" #2052

Merged
merged 3 commits into from
Jan 29, 2018
Merged

Update all component display names to "Blueprint2.X" #2052

merged 3 commits into from
Jan 29, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jan 29, 2018 •
edited
Loading

Fixes #2049

  • docs-theme uses Docs.X display names. Should I a) make those Docs2.X or b) Blueprint2.X?

@blueprint-bot
Copy link

Blueprint2 displayName

Preview: documentation | landing | table

adidahiya
adidahiya approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with Docs2

@blueprint-bot
Copy link

fix NumericInput tests to do the right thing, and not assert on displayName

Preview: documentation | landing | table

@giladgray
Copy link
Contributor Author

image
and there it is! blueprint has 60 public components (+ 1 test file changed)

@blueprint-bot
Copy link

Docs.X => Docs2.X

Preview: documentation | landing | table

@giladgray giladgray merged commit 8f05618 into develop Jan 29, 2018
@giladgray giladgray deleted the gg/displayname2 branch January 29, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @adidahiya