switch to chrome headless, deflake tests #2056
Conversation
remove HACKHACKPreview: documentation | landing | table |
commentsPreview: documentation | landing | table |
table expected widthPreview: documentation | landing | table |
remove phantomjs dependenciesPreview: documentation | landing | table |
(a suite remain skipped in TableBody)
Utils.times negative numbersPreview: documentation | landing | table |
|
can you believe it's been so consistently green for so many runs??? |
|
@adidahiya i'm fairly sure that |
| // the next frame, not just to the end of the current frame. | ||
| function assertFocus(selector: string | (() => void), done: MochaDone) { | ||
| // the behavior being tested relies on requestAnimationFrame. | ||
| // to avoid flakiness, use nested setTimeouts to delay execution until the *next* frame. |
There was a problem hiding this comment.
this is still concerning, but at least this PR leaves us in a better state than the repo currently is...
There was a problem hiding this comment.
yes, it's definitely a better state. in the course of development, i saw test flakes locally with chrome headless where certain suites would go red for a run. but this hasn't shown itself on circle (greens all the way down), so that's good news.
Fixes #1951
Changes proposed in this pull request: