Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breadcrumbs] Remove floats, add flex support #2065

Merged
merged 1 commit into from
Feb 1, 2018
Merged

[Breadcrumbs] Remove floats, add flex support #2065

merged 1 commit into from
Feb 1, 2018

Conversation

llorca
Copy link
Contributor

@llorca llorca commented Feb 1, 2018 •
edited by giladgray
Loading

🔥 inline-block => flex display. (now it's a block element)

@llorca llorca requested a review from giladgray February 1, 2018 19:21
@blueprint-bot
Copy link

flex breadcrumbs

Preview: documentation | landing | table

@adidahiya adidahiya merged commit a45b9ed into develop Feb 1, 2018
@adidahiya adidahiya deleted the al/breadcrumbs-flex branch February 1, 2018 19:51
@giladgray
Copy link
Contributor

i don't think this is breaking. the API is intact.

actually inline-block => flex is arguably breaking. should have been inline-flex.

@llorca
Copy link
Contributor Author

llorca commented Feb 1, 2018

well, it merged before you got a chance to comment. should I follow up with a change to inline-flex?

@adidahiya
Copy link
Contributor

yeah feel free to change to inline-flex if it looks the same

@llorca llorca mentioned this pull request Feb 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

@giladgray giladgray Awaiting requested review from giladgray

Assignees
No one assigned
Labels
Type: breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llorca @blueprint-bot @giladgray @adidahiya