Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

followups from SVG Icons! #2069

Merged
merged 9 commits into from
Feb 2, 2018
Merged

followups from SVG Icons! #2069

merged 9 commits into from
Feb 2, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Feb 1, 2018 •
edited
Loading

From #2028 (comment).

see commits.

@blueprint-bot
Copy link

TreeNode caret uses Icon (and caret icon, nee chevron)

Preview: documentation | landing | table

@adidahiya
Copy link
Contributor

adidahiya commented Feb 2, 2018 •
edited by giladgray
Loading

  • timezone picker shouldn't be in labs docs
    image
  • this alert CSS is almost certainly wrong
    image
    • also, clicking Move to Trash here doesn't do the right thing -- it produces a console error

adidahiya
adidahiya approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@blueprint-bot
Copy link

remove TZP from labs

Preview: documentation | landing | table

@giladgray giladgray merged commit 44f997e into develop Feb 2, 2018
@giladgray giladgray deleted the gg/svg-icons-flup branch February 2, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

@llorca llorca Awaiting requested review from llorca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @adidahiya