short icon names only #2072
Merged
short icon names only #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 2, 2018 12:24
…of one object. upside is they're all string literals without the `as` cast.
IconName becomes derived type from shape of IconNames
adidahiya
approved these changes
Feb 2, 2018
| @@ -24,7 +24,8 @@ describe("<Icon>", () => { | |||
|
|
|||
| it("renders iconName class", () => assertIcon(<Icon iconName="calendar" />, "calendar")); | |||
|
|
|||
| it("supports prefixed iconName", () => assertIcon(<Icon iconName={IconClasses.AIRPLANE} />, "airplane")); | |||
| // uncomment for compiler error | |||
| // it("does not support prefixed iconName", () => assertIcon(<Icon iconName="pt-icon-airplane" />, "airplane")); | |||
There was a problem hiding this comment.
with TS 2.6 you can use // @ts-ignore to ignore the compiler error. then you could make this test verify that it doesn't render anything
remove normalizedIconName, ts-ignore test compiler errorPreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2067
Changes proposed in this pull request:
LegacyIconNametype and supportIconNamesmodule:export const ARROW_DOWN = "arrow-down"; ...ascast.import * asto glob generated consts into objects.IconNamebecomes derived type from shape ofIconNames. comes out the same and works identically in VS Code 👍