Remove remaining deprecated props #2073
Conversation
…se context instead
| @@ -78,7 +78,7 @@ export class BlueprintDocs extends React.Component<IBlueprintDocsProps, { themeN | |||
|
|
|||
| const match = /docs\/v([0-9]+)/.exec(location.href); | |||
| // default to latest release if we can't find a major version in the URL | |||
| const currentRelease = match == null ? versions[0].version : match[1]; | |||
| const currentRelease = match == null ? versions[versions.length - 1].version : match[1]; | |||
| <div className="pt-navbar-group"> | ||
| <Navigator items={nav} onNavigate={this.handleNavigation} /> | ||
| </div> | ||
| <div className="pt-navbar-group">{this.props.navbarRight}</div> | ||
| <div className="pt-navbar-group pt-navbar-group-right">{this.props.navbarRight}</div> |
There was a problem hiding this comment.
we have components for Navbar etc, but whatever
|
|
||
| export const ROW_HEADER_CELL_MENU_DEPRECATED = | ||
| deprec + ` <RowHeaderCell> menu is deprecated. Use menuRenderer instead.`; | ||
| // const deprec = `${ns} DEPRECATION:`; |
There was a problem hiding this comment.
eh, sort of on purpose. will be useful as a reminder for future deprecation messages 🤷♂️
| isActive: false, | ||
| menuIconName: "chevron-down", | ||
| }; | ||
|
|
||
| public static contextTypes: React.ValidationMap< | ||
| IColumnInteractionBarContextTypes | ||
| > = columnInteractionBarContextTypes; |
There was a problem hiding this comment.
shouldn't need React.ValidationMap... type info. let it come from columnInteractionBarContextTypes
There was a problem hiding this comment.
you do need it. there's a whole "typescript cannot name this type even though it knows where it comes from" rabbit hole which I won't bother explaining here
| @@ -425,6 +422,10 @@ export class Table extends AbstractComponent<ITableProps, ITableState> { | |||
| selectionModes: SelectionModes.ALL, | |||
| }; | |||
|
|
|||
| public static childContextTypes: React.ValidationMap< | |||
| IColumnInteractionBarContextTypes | |||
| > = columnInteractionBarContextTypes; | |||
There was a problem hiding this comment.
public static childContextTypes = columnInteractionBarContextTypes should do it.
fix bad importPreview: documentation | landing | table |
Fix table testsPreview: documentation | landing | table |
Fixes #2019