refactor icons.json #2084
Merged
refactor icons.json #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icons.json name=>displayName, className=>iconNamePreview: documentation | landing | table |
adidahiya
reviewed
Feb 6, 2018
| function toShortName(icon) { | ||
| return icon.className.replace("pt-icon-", ""); | ||
| /** | ||
| * Removes `pt-icon-` prefix from icon className. |
There was a problem hiding this comment.
that's not what this does
| @@ -111,13 +112,13 @@ function exportIconConsts(valueGetter) { | |||
| async function buildPathsObject(objectName, size) { | |||
| return Promise.all( | |||
| ICONS_METADATA.map(async icon => { | |||
| const filepath = path.resolve(__dirname, `../../resources/icons/${size}px/${icon.className}.svg`); | |||
| const filepath = path.resolve(__dirname, `../../resources/icons/${size}px/${toLongName(icon)}.svg`); | |||
There was a problem hiding this comment.
can we batch rename the SVG files too? no need for pt- in the filename
added 2 commits
February 5, 2018 17:17
also chmod -x all these files (why were they executable in the first place??)
giladgray
commented
Feb 6, 2018
|
|
||
| // map ENUM_NAME to pt-icon-class-name | ||
| writeLinesToFile("iconClasses.ts", ...exportIconConsts(icon => icon.className)); | ||
| writeLinesToFile("iconClasses.ts", ...exportIconConsts(toLongName)); |
There was a problem hiding this comment.
@adidahiya thoughts on deleting this file as it's simply Classes.iconClass(IconNames.AIRPLANE)?
There was a problem hiding this comment.
hm yeah I guess that's fine... can you add it to the migration script?
docsPreview: documentation | landing | table |
adidahiya
approved these changes
Feb 6, 2018
|
are you going to delete |
|
separate PR
…On Tue, Feb 6, 2018 at 12:45 PM Adi Dahiya ***@***.***> wrote:
are you going to delete iconClasses.ts?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2084 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAcXttijKVXMo_KyZ2VdGPCAie6wlNR2ks5tSLnlgaJpZM4R6I-j>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
icons.jsonname=>displayName, className=>iconNameclassNamewithpt-icon-prefix is a bunch of crufty data, esp given iconName => icon prop #2070generate-icons-sourceReviewers should focus on:
this PR should fix the broken Icons page in #2070
new record for most files changed?
870