QueryList predicate type aliases #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move itemRenderer file into select/commonPreview: documentation | landing | table |
adidahiya
approved these changes
Feb 6, 2018
| @@ -20,6 +20,8 @@ export interface IListItemsProps<T> extends IProps { | |||
| * (Supports filter algorithms that operate on the entire set, rather than individual items.) | |||
| * | |||
| * If defined with `itemPredicate`, this prop takes priority and the other will be ignored. | |||
| * | |||
| * An alias type `ItemListPredicate<T>` is provided to simplify the process of authoring predicates. | |||
There was a problem hiding this comment.
then why not use the alias here in the typedef?
There was a problem hiding this comment.
i want it to show the full signature in the docs, not the type alias name
There was a problem hiding this comment.
but you should be able to click on it to see the full def. I don't like this compromise 🙅♂️
Merged
use alias types in interfacePreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ItemPredicate<T>andItemListPredicate<T>(a laItemRenderer<T>)