[core] add support for more Alert props #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionDuration props
Alert: add canEscapeKeyCancel, canOutsideClickCancel, onClose, transitionDuration propsPreview: documentation | landing | table |
llorca
approved these changes
Feb 7, 2018
invliD
approved these changes
Feb 8, 2018
packages/core/src/common/errors.ts
Outdated
| @@ -9,6 +9,8 @@ const ns = "[Blueprint]"; | |||
| export const CLAMP_MIN_MAX = ns + ` clamp: max cannot be less than min`; | |||
|
|
|||
| export const ALERT_WARN_CANCEL_PROPS = ns + ` <Alert> cancelButtonText and onCancel should be set together.`; | |||
| export const ALERT_WARN_CANCEL_ESCAPE_KEY = ns + ` <Alert> canEscapeKeyCancel enabled without onCancel handler.`; | |||
| export const ALERT_WARN_CANCEL_OUTSIDE_CLICK = ns + ` <Alert> canOutsideClickCancel enbaled without onCancel handler.`; | |||
There was a problem hiding this comment.
These are misleading given onClose is also ok.
There was a problem hiding this comment.
oh yeah gotta update language
adidahiya
reviewed
Feb 8, 2018
| /** | ||
| * Handler invoked when the Alert is confirmed or canceled; see `onConfirm` and `onCancel` for more details. | ||
| * First argument is `true` if confirmed, `false` otherwise. | ||
| * This is an alternative to defining separate `onConfirm` and `onCancel` handlers. |
There was a problem hiding this comment.
why support 3 handlers when one will do? either remove this (leave the callbacks as-is) or remove the existing ones and only support onClose
There was a problem hiding this comment.
TagInput also has three callbacks, as does EditableText
adidahiya
changed the title
Update errors.tsPreview: documentation | landing | table |
lintPreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517
Changes proposed in this pull request:
Alert: addcanEscapeKeyCancel,canOutsideClickCancel,onClose,transitionDurationpropsonCloseis single alternative to separateonCancel/onConfirmpropscan*CancelpropscanEnterKeyConfirm(see Alert doesn’t have canEscapeKeyClose nor canReturnKeyConfirm #517) because it's not easy to implement (key events require focus, blah blah), and is already supported by simplytab-ing onto a button and pressingenterorspace