sync table quadrants whenever col widths or row heights from props ch… #2118
Conversation
giladgray
requested review from
cmslewis,
themadcreator and
gscshoyru
and removed request for
cmslewis
|
@mcintyret this is targeting |
packages/table/src/table.tsx
Outdated
| @@ -730,6 +730,13 @@ export class Table extends AbstractComponent<ITableProps, ITableState> { | |||
| newSelectedRegions, | |||
| ); | |||
|
|
|||
| if ( | |||
There was a problem hiding this comment.
nit: can we put this up on line 713 to co-locate it with the code that updates newColumnWidths and newRowHeights?
packages/table/src/table.tsx
Outdated
| !CoreUtils.arraysEqual(newColumnWidths, this.state.columnWidths) || | ||
| !CoreUtils.arraysEqual(newRowHeights, this.state.rowHeights) | ||
| ) { | ||
| this.didUpdateColumnOrRowSizes = true; |
There was a problem hiding this comment.
I see that in other places we call this.invalidateGrid() when we set this to true. It looks like that's not strictly necessary since it's called 4 lines later, but maybe add a comment
There was a problem hiding this comment.
I could just move up the invalidateGrid() call to just below this block? Not sure what I would be trying to explain in a comment
|
@giladgray thanks for the heads up. I don't think this fix is massively urgent as I don't expect people to hit it much, just noticed it as I was playing around. If that changes I'll make another PR. |
|
@mcintyret just pushed a commit to address the one outstanding comment. will merge after ✅ |
This fixes an edge case where columns are moved from the unfrozen to the frozen area, and column widths are provided such that the moved column retains its width. Prior to this change such a move would look like this:
before moving:
after moving:
With this change it works as expected