TypeScript 2.7 + esModuleInterop #2200

giladgray · 2018-03-04T00:54:52Z

Fixes #2144

verify compiled files work

Changes proposed in this pull request:

typescript 2.7 and enable esModuleInterop and allowSyntheticDefaultImports
documentalist 1.1.0 for latest typedoc with 2.7 support
tslib 1.9.0 for new helpers
- ⚠️ dependency bump in all packages, 1.5 => 1.9

blueprint-bot · 2018-03-04T03:12:02Z

fix datetime example imports

Preview: documentation | landing | table

adidahiya · 2018-03-07T16:59:11Z

packages/core/src/components/alert/alert.tsx

@@ -4,7 +4,7 @@
 * Licensed under the terms of the LICENSE file distributed with this project.
 */

-import * as classNames from "classnames";
+import classNames from "classnames";
 import * as React from "react";


don't we need to do the same for all import * statements? I believe namespace imports are now discouraged altogether, so we should make that change across the board in this PR.

This only needed for things that are effectively “module.exports = something” and don’t have flags marking them as originally es modules.

TS has been doing synthetic wrong. Now you’re doing it right! (Namespaces are not invocable)

seems the only offenders were classnames, moment, moment-timezone

cool, so we're still blocking this PR on fixing import * as moment right?

no i did that
https://github.com/palantir/blueprint/pull/2200/files#diff-a17a0b10439cd3aaa22383abd9c6b2feR41

adidahiya · 2018-03-07T17:01:15Z

yarn.lock

-typescript@2.4.1:
-  version "2.4.1"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.4.1.tgz#c3ccb16ddaa0b2314de031e7e6fee89e5ba346bc"
+typescript@2.7.1:


can you use yarn why to find out why we have this constraint? I don't want to be pinned to 2.7.1 anywhere, it has bugs.

oh this is from typedoc for sure https://github.com/TypeStrong/typedoc/releases/tag/v0.10.0

TypeStrong/typedoc#718

womp. I filed TypeStrong/typedoc#720

👍 they're slightly different requests

ok... given the response on my issue, I think we'll have to live with this.

yeah for now. on my issue he said he'd have something next week for 2.7.2

Hey guys, I've released a patch update to TypeDoc which updates Typescript to 2.7.2

adidahiya · 2018-03-07T17:02:20Z

does this work with consumers using older TS versions? do they also have to enable the esModuleInterop to consume our typings? if they do, that's probably ok, it's a small break -- I'm sure most people are using named imports rather than import * as Blueprint from "@blueprintjs/core"

adidahiya · 2018-03-07T17:02:36Z

@ericanderson IIRC you're using rollup on some projects? Mind taking a look at this PR?

ericanderson · 2018-03-08T17:44:06Z

packages/core/src/components/alert/alert.tsx

@@ -4,7 +4,7 @@
 * Licensed under the terms of the LICENSE file distributed with this project.
 */

-import * as classNames from "classnames";
+import classNames from "classnames";
 import * as React from "react";


This only needed for things that are effectively “module.exports = something” and don’t have flags marking them as originally es modules.

TS has been doing synthetic wrong. Now you’re doing it right! (Namespaces are not invocable)

ericanderson · 2018-03-08T17:48:22Z

The JavaScript generated from doing this is usable by webpack, rollup, and node. What’s funny is for rollup we actually had to write plugins to convert es code from “import * as X from “Y”” to drop the star as. The es modules you were publishing before were actually wrong and are now correct

adidahiya · 2018-03-08T18:47:20Z

The es modules you were publishing before were actually wrong and are now correct

yes, that's the linked issue #2144 we're trying to fix

adidahiya

ah, you're right, I missed the moment stuff. lgtm, just fix the tslib dependency range

adidahiya · 2018-03-08T18:59:40Z

packages/datetime/package.json

@@ -33,7 +33,7 @@
    "@blueprintjs/core": "^2.0.0-rc.2",
    "classnames": "^2.2",
    "react-day-picker": "^7.0.7",
-    "tslib": "^1.5.0"
+    "tslib": "^1.9.0"


I think all of these need to be ~1.9.0, similar to the typescript version range

i don't think so, it's really a minimum for the new functions added to support esModuleInterop

Hmm, I thought that the behavior of these functions can change across minor versions... but that doesn't seem to be the case looking at its README. We do it for internal libraries, but this should be fine; we should probably switch over to a ^ range

switch what over to ^ range?

makes sense to leave typescript with ~ to allow patches but exclude minors (cuz those can change things significantly)

sorry, I meant switch our internal libraries which use "tslib": "~ over to ^. unrelated to this PR.

adidahiya · 2018-03-12T22:12:38Z

I'll take this over and finish it up, hoping to publish a 2.0.0-rc.3 with this

blueprint-bot · 2018-03-12T22:28:57Z

semantic merge conflcit

Preview: documentation | landing | table

Gilad Gray added 5 commits March 3, 2018 16:10

ts2.7, enable esModuleInterop and allowSyntheticDefaultImports

1c7eec8

replace classNames import syntax

4d7935c

documentalist 1.1.0 so it's ts 2.7 all the way down

6f0c691

tslib 1.9 for new helpers

317ff1a

fix compile errors

0a6c049

giladgray requested a review from adidahiya March 4, 2018 00:54

fix datetime example imports

eb7295c

giladgray added the Domain: tooling label Mar 4, 2018

adidahiya suggested changes Mar 7, 2018

View reviewed changes

adidahiya requested a review from ericanderson March 7, 2018 17:02

ericanderson approved these changes Mar 8, 2018

View reviewed changes

adidahiya approved these changes Mar 8, 2018

View reviewed changes

giladgray mentioned this pull request Mar 12, 2018

Error when compiling blueprint with rollup #2221

Closed

Merge branch 'develop' into gg/esmoduleinterop

6976029

adidahiya added 2 commits March 12, 2018 18:18

Address new TS definite assignment check

8c29451

semantic merge conflcit

820e509

adidahiya merged commit 367480a into develop Mar 12, 2018

adidahiya deleted the gg/esmoduleinterop branch March 12, 2018 22:31

giladgray mentioned this pull request Mar 13, 2018

Prepare Release v2.0.0-rc.3 #2222

Merged

layershifter mentioned this pull request Nov 30, 2018

Impossible to build project with Parcel or Rollup microsoft/fluent-ui-react#547

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TypeScript 2.7 + esModuleInterop #2200

TypeScript 2.7 + esModuleInterop #2200

giladgray commented Mar 4, 2018 •

edited

Loading

blueprint-bot commented Mar 4, 2018

adidahiya Mar 7, 2018

ericanderson Mar 8, 2018

giladgray Mar 8, 2018

adidahiya Mar 8, 2018

giladgray Mar 8, 2018 •

edited

Loading

adidahiya Mar 7, 2018

giladgray Mar 8, 2018

giladgray Mar 8, 2018

adidahiya Mar 8, 2018

giladgray Mar 8, 2018

adidahiya Mar 8, 2018

giladgray Mar 8, 2018

aciccarello Mar 9, 2018

adidahiya commented Mar 7, 2018 •

edited

Loading

adidahiya commented Mar 7, 2018

ericanderson Mar 8, 2018

ericanderson commented Mar 8, 2018

adidahiya commented Mar 8, 2018

adidahiya left a comment

adidahiya Mar 8, 2018

giladgray Mar 8, 2018

adidahiya Mar 8, 2018

giladgray Mar 8, 2018

adidahiya Mar 8, 2018

adidahiya commented Mar 12, 2018

blueprint-bot commented Mar 12, 2018

TypeScript 2.7 + esModuleInterop #2200

TypeScript 2.7 + esModuleInterop #2200

Conversation

giladgray commented Mar 4, 2018 • edited Loading

Fixes #2144

Changes proposed in this pull request:

blueprint-bot commented Mar 4, 2018

fix datetime example imports

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giladgray Mar 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adidahiya commented Mar 7, 2018 • edited Loading

adidahiya commented Mar 7, 2018

Choose a reason for hiding this comment

ericanderson commented Mar 8, 2018

adidahiya commented Mar 8, 2018

adidahiya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adidahiya commented Mar 12, 2018

blueprint-bot commented Mar 12, 2018

semantic merge conflcit

giladgray commented Mar 4, 2018 •

edited

Loading

giladgray Mar 8, 2018 •

edited

Loading

adidahiya commented Mar 7, 2018 •

edited

Loading