Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] fixes #2135 - Adds a blur explicitly when escape key is pressed #2208

Merged

Conversation

danielbh
Copy link
Contributor

@danielbh danielbh commented Mar 7, 2018

Fixes #2135

Changes proposed in this pull request:

Pressing the escape key will now close the MultiSelect Popover when it is open and the input field is focused. An escape keypress will also now blur the input field.

@danielbh
Copy link
Contributor Author

danielbh commented Mar 7, 2018

[Select] fixes #2135 - Adds a blur explicitly when escape key is pressed.

Preview: documentation | landing | table

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! this same line appears in Suggest so it should be here too.

@giladgray giladgray merged commit b884410 into palantir:develop Mar 7, 2018
@danielbh
Copy link
Contributor Author

danielbh commented Mar 7, 2018

Good to know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow esc key to hide multiselect options
2 participants