Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass inputRef to <Suggest> & <MultiSelect> #2216

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

alxmiron
Copy link
Contributor

@alxmiron alxmiron commented Mar 8, 2018

Updated #2079 PR for latest 2.0 branch

@alxmiron
Copy link
Contributor Author

alxmiron commented Mar 8, 2018

Pass inputRef to &

Preview: documentation | landing | table

@alxmiron
Copy link
Contributor Author

alxmiron commented Mar 8, 2018

@giladgray Am I missing something? Why I can't get green status from compile, lint & install CI jobs? http://prntscr.com/iofkpl

@giladgray
Copy link
Contributor

huh weird. @alxmiron it looks like the entire build ran green but it wasn't reported properly to github: https://circleci.com/workflow-run/5dca9b59-a108-4397-9556-8063f1b72234

try re-running it?

@alxmiron
Copy link
Contributor Author

alxmiron commented Mar 8, 2018

Pass inputRef to &

Preview: documentation | landing | table

@giladgray
Copy link
Contributor

giladgray commented Mar 8, 2018

@alxmiron test flake. re-run failed job from dropdown here https://circleci.com/gh/HiTask/workflows/blueprint/tree/am%2Fselect-input-ref
image

(i tried, but i can't do it for you)

@alxmiron
Copy link
Contributor Author

alxmiron commented Mar 8, 2018

Pass inputRef to &

Preview: documentation | landing | table

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dig it 🎉

@giladgray giladgray merged commit d6da21c into palantir:develop Mar 8, 2018
@alxmiron alxmiron deleted the am/select-input-ref branch March 12, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants