add border to first tbody > tr > th #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @VictorHom! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
giladgray
suggested changes
Mar 31, 2018
| tbody tr:first-child td { | ||
| box-shadow: inset 0 $table-border-width 0 0 $dark-table-border-color; | ||
| } | ||
| tbody tr:first-child{ |
There was a problem hiding this comment.
Missing a space between selector and {
VictorHom
force-pushed
the
vh/border_top_first_row_header
branch
from
12fb734
to
e5f9bd0
Compare
llorca
approved these changes
Apr 2, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2215
Changes proposed in this pull request:
Adding a border top as requested in #2215
Reviewers should focus on:
first time looking at the codebase, so I am not familiar if I am missing any pieces. All feedback welcomed.