[datetime] Increase gap between month selection text and caret #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually use font-family: inheritPreview: documentation | landing | table |
|
@reiv i think the right thing to do here is to upgrade to normalize.css v8.0 which includes this exact fix: https://github.com/necolas/normalize.css/blob/master/CHANGELOG.md#800-february-2-2018
|
|
@giladgray Neat! There's four other instances of |
|
@reiv go for it! |
Revert font-family CSS rule changesPreview: documentation | landing | table |
reiv
changed the title
giladgray
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR addsSplit off into #2362.font-family: inheritrules to the<select>and<input>elements used in the components of this package. Previously, these were set to the browser defaults (sans-serif); now, they should use the correct font stack.In particular, this fixes an issue where the caret of the month selector was overlapping the text, like this:
(That's because the
measureTextWidthfunction was producing measurements that incorrectly assumed the body font stack.)This PR also adds 5px of extra space between the text and caret -- it looked off with no gap at all.
By the way, I think that the
TimePickershould perhaps be displayed in a monospace font (an additional visual cue that this input field accepts time values), but that might be too opinionated so I left it atinheritfor now.