Fix #2095: Hot reload Table #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @dan-katz! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
giladgray
suggested changes
Apr 13, 2018
packages/table/src/common/utils.ts
Outdated
| @@ -329,6 +331,10 @@ export const Utils = { | |||
| const approxCellHeight = approxNumLinesDesired * approxLineHeight; | |||
| return approxCellHeight; | |||
| }, | |||
|
|
|||
| isElementOfType<P = {}>(element: any, ComponentClass: React.ComponentClass<P>): element is React.ReactElement<P> { | |||
There was a problem hiding this comment.
🙅♂️ import { Utils } from "@blueprintjs/core" instead of copying code
packages/table/src/cell/cell.tsx
Outdated
| @@ -10,6 +10,7 @@ import * as Classes from "../common/classes"; | |||
| import { Classes as CoreClasses, IIntentProps, IProps, Utils as CoreUtils } from "@blueprintjs/core"; | |||
|
|
|||
| import { LoadableContent } from "../common/loadableContent"; | |||
| import { Utils } from "../common/utils"; | |||
There was a problem hiding this comment.
import { Utils } from "@blueprintjs/core"
use isElementOfType util function from corePreview: documentation | landing | table |
fix linting errorsPreview: documentation | landing | table |
|
whohooo!!! Thanks @dan-katz ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2095
Checklist
Changes proposed in this pull request:
Add the isElementOfType function from PR 2099 to the Table package and use it for element comparison in the Table and Cell components.
Reviewers should focus on:
Ensuring that the Table and Cell components still work as expected