[Tag] Add icon and rightIcon props

[llorca]

[blueprint-bot]

different rightIcon

Preview: documentation | landing | table

[dmackerman]

Super minor nit, the icon feels a bit...big? Might just be some visual trickery.

We have some tags with icons inside of them that end up looking like:

Just custom CSS to render the Icon at 12px.

[llorca]

you're right, but since 2.0, you can put any SVG in icon props, not just a Blueprint one. I highly discourage using a default 16px icon in there, or resizing a 16px one to 12. On our end, we use custom made 12px icons to ensure crispness

[llorca]

for some reason, when showing the left icon only (not the right one), the stray div container's height increases by 2px... any idea how to go around that?

[blueprint-bot]

remove unnecessary flex

Preview: documentation | landing | table

[giladgray]

soooo this is already technically possible since you can just put JSX in <Tag> elements, so you can do <Tag><Icon />content<Icon /></Tag>. all we really need to do is fix the spacing, and i think the best way to do that is along the lines of how pt-flex-container() mixin will automatically put margin after all elements except the last, rather than using the align classes.

i'm happy to pick this up at some point next week.

[blueprint-bot]

Merge branch 'develop' of github.com:palantir/blueprint into al/tag-icons

Preview: documentation | landing | table

[blueprint-bot]

fix tag-input line-height

Preview: documentation | landing | table

[blueprint-bot]

fix tests

Preview: documentation | landing | table

[giladgray]

🤔 multiline support is poor here

[blueprint-bot]

add Tag multiline prop and Text tagName prop (to use span)

Preview: documentation | landing | table

[blueprint-bot]

fix test

Preview: documentation | landing | table

[themadcreator]

Just my opinion but the the tags seem to be too small to fit normal-sized icons.

Also, the contrast is too high and it doesn't look good until you enable minimal styling:

[themadcreator]

another breaking change to make note of in release notes

[giladgray]

def, tho it only affects CSS consumers. #2587

[blueprint-bot]

remove tag-removable from docs

Preview: documentation | landing | table