[Icons] Added shield icon #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added shield iconPreview: documentation | landing | table |
invliD
approved these changes
Apr 30, 2018
llorca
approved these changes
Apr 30, 2018
There was a problem hiding this comment.
looking good! @giladgray double checking, this will be SVGO-optimized after it merges right?
giladgray
approved these changes
Apr 30, 2018
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <svg width="16px" height="16px" viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | |||
| <!-- Generator: Sketch 49.2 (51160) - http://www.bohemiancoding.com/sketch --> | |||
There was a problem hiding this comment.
🤔 this markup looks quite different from the other icons... seems the others were generated with Illustrator but this one with Sketch. not a problem, just noting an observation.
There was a problem hiding this comment.
yeah, the markup differs between these two. Currently we have a mix of Sketch and AI exported icons.
|
@llorca it gets SVGO'ed at compile time, not at PR merge time! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shield icon added