-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change CSS namespace to bp3
#2441
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright 2015 Palantir Technologies, Inc. All rights reserved. | ||
// Licensed under the terms of the LICENSE file distributed with this project. | ||
|
||
@import "common/variables"; | ||
@import "common/mixins"; | ||
|
||
// Style resets on top of Normalize.css | ||
|
||
|
||
body { | ||
@include base-typography(); | ||
color: $pt-text-color; | ||
} | ||
|
||
p { | ||
margin-top: 0; | ||
margin-bottom: $pt-grid-size; | ||
} | ||
|
||
small { | ||
font-size: $pt-font-size-small; | ||
} | ||
|
||
strong { | ||
font-weight: 600; | ||
} | ||
|
||
// consistent cross-browser text selection | ||
::selection { | ||
background: $pt-text-selection-color; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,7 @@ | |
@import "generated/icon-variables"; | ||
@import "generated/icon-map"; | ||
|
||
$pt-namespace: "pt" !default; | ||
$ns: $pt-namespace; | ||
$ns: "bp3" !default; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we not import that from core? how does it work for other packages that contain CSS? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❌ other way around... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh right, I forget. is that tentatively changing to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nope no such plans. still core > icons |
||
|
||
$icon-classes: ( | ||
".#{$ns}-icon", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 thanks