[Tree] Fix a few regressions #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
llorca
commented
May 4, 2018
llorca
commented
- Proper icon color
- Proper popover wrapper/target centering in secondary label
- Chevron icon for animated expand icon
- Improve example
center popover wrappers/targets in secondary labelPreview: documentation | landing | table |
giladgray
suggested changes
May 21, 2018
| } | ||
|
|
||
| .#{$ns}-icon { | ||
| margin: $tree-icon-spacing; | ||
| } | ||
| } | ||
|
|
||
| #{$icon-classes} { | ||
| color: $pt-icon-color; |
There was a problem hiding this comment.
❌ this selector is not scoped!!!! if you actually want to change all icons default colors then this is not the correct file. but i suspect you just want to scope this.
|
also merge conflicts |
giladgray
suggested changes
May 21, 2018
| @@ -127,6 +130,12 @@ $tree-icon-spacing: ($tree-row-height - $pt-icon-size-standard) / 2 !default; | |||
| padding: 0 ($pt-grid-size / 2); | |||
| line-height: $tree-row-height; | |||
merge conflictsPreview: documentation | landing | table |
scope icon colorPreview: documentation | landing | table |
test refactorsPreviews: documentation | landing | table |
test refactorsPreviews: documentation | landing | table |
remove line-heightPreviews: documentation | landing | table |
themadcreator
approved these changes
Oct 4, 2018
giladgray
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.