refactor Spinner, kill SVGSpinner #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 8, 2018 11:34
- remove all wrapper elements so svg is the root - overflow:visible means no need to switch viewBox anymore! - animate only the track head path, not the whole thing - add style prop
themadcreator
approved these changes
May 8, 2018
| .#{$ns}-spinner { | ||
| @include spinner-size($spinner-width-factor, $spinner-stroke-width, $spinner-speed); | ||
| // allow paths to overflow container -- critical for edges of circles! | ||
| overflow: visible; | ||
| vertical-align: top; |
There was a problem hiding this comment.
is vertical align necessary? is this going to mess with existing uses?
There was a problem hiding this comment.
hmm good thought. i'll change to middle
|
need to add |
vertical-align, set height alongside widthPreview: documentation | landing | table |
llorca
reviewed
May 8, 2018
| @@ -193,8 +193,6 @@ export const SPINNER = `${NS}-spinner`; | |||
| export const SPINNER_HEAD = `${SPINNER}-head`; | |||
| export const SPINNER_NO_SPIN = `${NS}-no-spin`; | |||
There was a problem hiding this comment.
while we're at it, thoughts on a better name for this? something more generic like .pt-static maybe? or maybe indeterminate vs determinate loading?
There was a problem hiding this comment.
meh i have no problems with this name. there's also PROGRESS_NO_STRIPES/ANIMATION
llorca
reviewed
May 8, 2018
| <div className={classes}> | ||
| <div className={Classes.SPINNER_SVG_CONTAINER}>{content}</div> | ||
| </div> | ||
| <svg className={classes} viewBox="0 0 100 100"> |
There was a problem hiding this comment.
I don't fully understand SVG/viewBox and stuff, but it's amazing that you were able to dramatically simplify
llorca
reviewed
May 8, 2018
llorca
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinnermarkup considerably:overflow:visiblemeans no need to switch viewBox anymore!SVGSpinnersinceSpinnercan now be used inside an SVG (no DOM elements)Classes.SPINNER_SVG_CONTAINERandClasses.SVG_SPINNER