Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensureElement wraps React Fragment #2499

Merged
merged 2 commits into from
May 14, 2018
Merged

Conversation

giladgray
Copy link
Contributor

Fixes #2498

React.Fragment elements have type Symbol(react.fragment), so now we check and wrap symbol types.

I also added unit tests for this util, including one that only runs in React 16!

@giladgray giladgray requested a review from llorca May 14, 2018 21:29
@blueprint-bot
Copy link

ensureElement wraps React Fragment in tag (and tests!!)

Preview: documentation | landing | table

Copy link
Contributor

@llorca llorca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!

@blueprint-bot
Copy link

undefined support

Preview: documentation | landing | table

@giladgray giladgray merged commit 5bf9748 into develop May 14, 2018
@giladgray giladgray deleted the gg/ensure-element-fragment branch May 14, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants