Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 move react-transition-group to regular dependency #2511

Merged
merged 2 commits into from
May 16, 2018
Merged

📦 move react-transition-group to regular dependency #2511

merged 2 commits into from
May 16, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented May 16, 2018 •
edited
Loading

  • it's been a peer dependency forever but I don't think this is correct, and is often a source of upgrade pain to users
  • most libraries declare react and react-dom as peer deps (r-t-g does this too) so it seems reasonable for that to be the minimal set of peer deps
  • r-t-g is not exposed in our APIs so it can be a normal dependency

Gilad Gray added 2 commits May 16, 2018 13:21
@blueprint-bot
Copy link

remove r-t-g from getting-started docs

Preview: documentation | landing | table

jkillian
jkillian approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@jkillian jkillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also follows with the official recommendation: reactjs/react-transition-group#32

@giladgray giladgray merged commit a866049 into develop May 16, 2018
@giladgray giladgray deleted the gg/rtg-dep branch May 16, 2018 20:47
@giladgray giladgray mentioned this pull request Jul 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkillian jkillian jkillian approved these changes

@themadcreator themadcreator Awaiting requested review from themadcreator

@adidahiya adidahiya Awaiting requested review from adidahiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @jkillian