Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Toaster.create errors if ReactDOM.render returns null #2523

Merged
merged 1 commit into from
May 18, 2018
Merged

[1.x] Toaster.create errors if ReactDOM.render returns null #2523

merged 1 commit into from
May 18, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray requested a review from invliD May 18, 2018 21:36
invliD
invliD approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@invliD invliD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@giladgray giladgray merged commit ab7edde into release/1.x May 18, 2018
@giladgray giladgray deleted the gg/toaster-lifecycle-1.x branch May 18, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @invliD @blueprint-bot