Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Common] Adding 'round' to the INVALID_PROPS list #2527

Merged
merged 1 commit into from
May 21, 2018
Merged

[Common] Adding 'round' to the INVALID_PROPS list #2527

merged 1 commit into from
May 21, 2018

Conversation

badams
Copy link
Contributor

@badams badams commented May 20, 2018

Fixes #2508

Checklist

Changes proposed in this pull request:

Add "round" to the list of invalid html props, this will prevent the round prop being passed through to the the HTML Input element here.

Reviewers should focus on:

I've incorporated this prop into the existing tests for this utility function, but not for the InputGroup component itself.

Round does not appear to be a valid html attribute so adding it to this list should be fine

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @badams! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@badams badams changed the title [Common] Adding \'round\' to the INVALID_PROPS list (#2508) [Common] Adding 'round' to the INVALID_PROPS list (#2508) May 20, 2018
@giladgray giladgray changed the title [Common] Adding 'round' to the INVALID_PROPS list (#2508) [Common] Adding 'round' to the INVALID_PROPS list May 21, 2018
Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, nice!

@giladgray giladgray merged commit 2c7f010 into palantir:develop May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants