Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add overflow list component #2537

Merged
merged 30 commits into from
Jun 1, 2018
Merged

[Core] Add overflow list component #2537

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6397f7b
Add overflow list component
invliD May 22, 2018
c898836
Refactor throttle
invliD May 22, 2018
a4c2732
Add iso test props
invliD May 22, 2018
3d8b20d
Unnest spacer css
invliD May 22, 2018
877917f
Remove constructor
invliD May 22, 2018
7cd0698
Clarify overflow
invliD May 22, 2018
26aea39
Improve legibility of repartition method
invliD May 22, 2018
9ae9eb2
Remove extraneous element measuring
invliD May 22, 2018
4a58756
Improve classes const definition
invliD May 22, 2018
fcec829
Stop measuring all elements on mount
invliD May 22, 2018
0fddce3
stuff
invliD May 22, 2018
412aef3
Add tests
invliD May 22, 2018
68d54e9
Add props to docs
invliD May 22, 2018
67706f1
Use breadcrumb component
invliD May 22, 2018
cd37872
Add props validation in willReceiveProps
invliD May 23, 2018
fd7ebdc
Fix comment
invliD May 23, 2018
6092dc2
Fix tests
invliD May 23, 2018
593b552
:(
invliD May 23, 2018
2fa5074
Update _examples.scss
invliD May 27, 2018
6b5590d
add some docs
llorca May 30, 2018
fe43b06
Update _overflow-list.scss
invliD May 31, 2018
e1712bd
Merge branch 'develop' into sb/overflow-list
giladgray May 31, 2018
ddd3253
no need for constructor
May 31, 2018
97632df
inline renderItems
May 31, 2018
f009f30
observer.disconnect() instead of manually unobserving each element
May 31, 2018
43975e2
clientWidth instead of getClientBB()
May 31, 2018
649c595
docs docs docs!
May 31, 2018
d796f4a
revert constructor and clientWidth
May 31, 2018
a226afc
docs edits
May 31, 2018
d76a0c4
Update overflow-list.md
invliD May 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/components/overflow-list/_overflow-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

.#{$ns}-overflow-list {
display: flex;
flex-wrap: nowrap;
min-width: 0;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/overflow-list/overflow-list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@# Overflow list

this is cool
`OverflowList` displays a list of items that can overflow on its own. The required `visibleItemRenderer` callback prop allows for customizing the appearance of visible items. The required `overflowRenderer` callback prop allows for customizing the rendering of collapsed items.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"on its own" means nothing. we should clarify what causes overflowing -- specifically, resize.


@reactExample OverflowListExample

Expand Down