[Core] support dark intent colors on icons #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support dark intent colors on iconsPreview: documentation | landing | table |
giladgray
suggested changes
May 29, 2018
| &.#{$ns}-intent-#{$intent} { | ||
| color: $color; | ||
| } | ||
|
|
||
| .#{$ns}-dark &.#{$ns}-intent-#{$intent} { |
There was a problem hiding this comment.
move this into the block above to avoid repitition.
&.intent {
color;
.dark & {
color;
}
}
|
|
||
| export interface IIconExampleState { | ||
| icon: IconName; | ||
| intent: Intent; |
There was a problem hiding this comment.
match alph below. make this last.
| @@ -38,16 +41,20 @@ export class IconExample extends React.PureComponent<IExampleProps, IIconExample | |||
| value={iconSize} | |||
| onChange={this.handleIconSizeChange} | |||
| /> | |||
| <H5>Example</H5> | |||
There was a problem hiding this comment.
nope, this is a prop! <Icon intent />
| </> | ||
| ); | ||
|
|
||
| return ( | ||
| <Example options={options} {...this.props}> | ||
| <Icon icon={icon} iconSize={iconSize} /> | ||
| <Icon icon={icon} iconSize={iconSize} className={Classes.intentClass(intent)} /> |
|
|
address commentsPreview: documentation | landing | table |
giladgray
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1745
also added a intent select in the icon example, so it's easy to test out