Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subsections to Core > Components in nav #2546

Merged
merged 4 commits into from
May 29, 2018
Merged

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented May 24, 2018

split core components into three groups: Components | Forms | Overlays. some open questions remain about where some components belong. and i have no idea how to sanely organize the Forms section.

image

left some comments in the code with bits that need work.

@@ -11,27 +13,49 @@
@page collapse
@page collapsible-list
@page context-menu
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is arguably an Overlay component

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it?

@page sliders
@page checkbox
@page switch
@page radio
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps one Toggles page for checkbox/switch/radio?

@page input-group
@page file-input
@page numeric-input
@page tag-input
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to group all the various inputs, but the Blah Input naming looks messy in nav.

@## Forms

@page form-group
@page control-group
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting these first as they're crucial concepts to using the form components


<!-- now people will read the Overlay docs!! -->
@page overlay
@page portal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two come first (intentionally breaking the alph) because they're basic concepts for this section.

@page alert
@## Elements

@page html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplest first

@@ -2,7 +2,9 @@

<!-- Exact ordering of components in the navbar: -->

@page alert
@## Elements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other groups are cool, except this one. let's remove it

@page progress-bar
@page skeleton
@page spinner
@page sliders
@page table-html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda feel like we should include this in HTML elements then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i disagree, it does much more than those components. has its own modifiers!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool

<!-- this guy's gonna go away shortly -->
@page label

@## Overlays
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@page text
@page tree

@## Forms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@llorca llorca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, some details

@giladgray
Copy link
Contributor Author

  • remove Elements
  • make headers 700 weight
  • make them all black

@giladgray giladgray changed the title [WIP] add subsections to Core > Components in nav: Elements, Forms, Overlays add subsections to Core > Components in nav: Elements, Forms, Overlays May 29, 2018
@giladgray giladgray changed the title add subsections to Core > Components in nav: Elements, Forms, Overlays add subsections to Core > Components in nav May 29, 2018
@blueprint-bot
Copy link

remove Elements, bold heading always black

Preview: documentation | landing | table

@llorca
Copy link
Contributor

llorca commented May 29, 2018

@giladgray small regression, package names look very thick now. can we bump back down to 600? everything else looks good.
image

@giladgray
Copy link
Contributor Author

dang i hit the wrong selector, my bad

@blueprint-bot
Copy link

move docs-nav-section to docs-app styles

Preview: documentation | landing | table

@giladgray giladgray merged commit c564a42 into develop May 29, 2018
@giladgray giladgray deleted the gg/core-components-nav branch May 29, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants