Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use default type params for HotkeysTarget & CMTarget #2554

Merged
merged 1 commit into from
Jun 2, 2018
Merged

use default type params for HotkeysTarget & CMTarget #2554

merged 1 commit into from
Jun 2, 2018

Conversation

giladgray
Copy link
Contributor

Fixes TS compiler errors like the following:

lerna ERR! ERROR in [at-loader] ../../node_modules/@blueprintjs/core/dist/esm/components/hotkeys/hotkeysTarget.d.ts:4:18
lerna ERR!     TS2320: Interface 'IHotkeysTarget' cannot simultaneously extend types 'Component<any, any, any>' and 'ComponentLifecycle<any, any, never>'.

@blueprint-bot
Copy link

use default type params for HotkeysTarget & CMTarget

Preview: documentation | landing | table

@giladgray giladgray requested a review from invliD June 1, 2018 21:42
@giladgray giladgray merged commit 6c81ba8 into develop Jun 2, 2018
@giladgray giladgray deleted the gg/decorator-types branch June 2, 2018 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

@themadcreator themadcreator Awaiting requested review from themadcreator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @invliD