Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] HTML Label component #2571

Merged
merged 4 commits into from
Jun 6, 2018
Merged

[core] HTML Label component #2571

merged 4 commits into from
Jun 6, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jun 5, 2018 •
edited
Loading

Fixes #2460

Changes proposed in this pull request:

  • 🔥 Label is now a simple HTML wrapper like Code or H1. no props modifiers.
    • prefer using FormGroup for all your React form needs
    • the complexity of two approaches was unnecessary, and FormGroup can handle any use case you throw at it (not true of Label)
  • refactor examples usage of component
    • this repo is probably the largest user of the Label component

@blueprint-bot
Copy link

fix Label usages in examples

Preview: documentation | landing | table

@giladgray giladgray requested review from invliD and removed request for themadcreator June 6, 2018 17:51
invliD
invliD approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@invliD invliD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@giladgray giladgray merged commit 381cbc7 into develop Jun 6, 2018
@giladgray giladgray deleted the gg/better-label branch June 6, 2018 20:57
@giladgray giladgray mentioned this pull request Jun 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

@llorca llorca Awaiting requested review from llorca

Assignees
No one assigned
Labels
Type: breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @invliD