Spinner size prop replaces small/large #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2018 17:11
compute styles in JS instead of hardcoded in CSS - remove most of the styles!
llorca
approved these changes
Jun 8, 2018
fix InputGroupPreview: documentation | landing | table |
invliD
reviewed
Jun 8, 2018
| * `Spinner.SIZE_STANDARD`, `Spinner.SIZE_LARGE`. | ||
| * @default Spinner.SIZE_STANDARD = 50 | ||
| */ | ||
| size?: number; |
There was a problem hiding this comment.
iconSize only allows passing in 16 or 20. Do we really want to support anything here?
There was a problem hiding this comment.
nope, you can pass any number: http://blueprintjs.com/docs/v2/#core/components/icon
but since icons are hinted at 16 and 20, you shouldn't use any other size unless you know exactly what you're doing. not true for spinners, they look good at any size
fix testsPreview: documentation | landing | table |
themadcreator
approved these changes
Jun 11, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Spinner size={30} />replaceslarge/smallsizing props. This works exactly likeiconSize.