Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defined a default empty value for tagInput's inputValue #2582

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

PrincipalsOffice
Copy link
Contributor

Fixes #2483

Checklist

Changes proposed in this pull request:

Added a default empty string value for the inputValue property, in order to correct the warning mentioned in the issue.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @PrincipalsOffice! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@PrincipalsOffice
Copy link
Contributor Author

defined a default empty value for tagInput's inputValue * fixed #2483

Preview: documentation | landing | table

@@ -175,7 +175,7 @@ export class TagInput extends AbstractPureComponent<ITagInputProps, ITagInputSta

public state: ITagInputState = {
activeIndex: NONE,
inputValue: this.props.inputValue,
inputValue: this.props.inputValue || "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ this belongs six lines up in the defaultProps object.

public static defaultProps = { ..., inputValue: "", ... }

@PrincipalsOffice
Copy link
Contributor Author

moved inputValue default declaration to defaultProps

Preview: documentation | landing | table

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! this'll ship in the next 3.0 beta release later this week.

@giladgray giladgray merged commit abdd375 into palantir:develop Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants