Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'unknown prop index on <div> tag' errors #2586

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Fix 'unknown prop index on <div> tag' errors #2586

merged 2 commits into from
Jun 11, 2018

Conversation

Que3216
Copy link
Contributor

@Que3216 Que3216 commented Jun 11, 2018 •
edited
Loading

Fixes #2533

(re-opening of #2534 -- sorry for the slow response on that one)

giladgray
giladgray approved these changes Jun 11, 2018
View reviewed changes
Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Que3216! looks great.

@giladgray giladgray merged commit f147ea6 into palantir:develop Jun 11, 2018
@giladgray
Copy link
Contributor

@Que3216 just so you're aware, this will ship in the next 3.0 beta release later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Que3216 @giladgray