MultiSlider fixes #2588
Merged
MultiSlider fixes #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MultiSlider fixesPreview: documentation | landing | table |
giladgray
reviewed
Jun 11, 2018
| <MultiSlider.Handle | ||
| value={value} | ||
| intentAfter={value < initialValue ? Intent.PRIMARY : undefined} | ||
| intentBefore={value >= initialValue ? Intent.PRIMARY : undefined} | ||
| onChange={onChange} | ||
| onRelease={onRelease} |
| @@ -369,9 +369,21 @@ export class MultiSlider extends AbstractPureComponent<IMultiSliderProps, ISlide | |||
| const oldValues = this.handleProps.map(handle => handle.value); | |||
| if (!Utils.arraysEqual(newValues, oldValues)) { | |||
| Utils.safeInvoke(this.props.onChange, newValues); | |||
| this.handleProps.forEach((handle, index) => { | |||
| if (oldValues[index] !== newValues[index]) { | |||
| @@ -37,9 +37,6 @@ export interface IHandleProps extends IProps { | |||
| /** Numeric value of this handle. */ | |||
| value: number; | |||
|
|
|||
| /** Whether this handle is non-interactive. */ | |||
| disabled?: boolean; | |||
There was a problem hiding this comment.
add this to IHandleInternalProps then? pretty sure it is respected in <Handle>
There was a problem hiding this comment.
tho it would be easy enough to support this prop, like you did with onChange/onRelease
Fix typingsPreview: documentation | landing | table |
giladgray
approved these changes
Jun 11, 2018
| @@ -37,9 +37,6 @@ export interface IHandleProps extends IProps { | |||
| /** Numeric value of this handle. */ | |||
| value: number; | |||
|
|
|||
| /** Whether this handle is non-interactive. */ | |||
| disabled?: boolean; | |||
There was a problem hiding this comment.
tho it would be easy enough to support this prop, like you did with onChange/onRelease
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes to MultiSlider before final merge