[docs] Navigator supports excluding items #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prop to hide the non-navigable headings
Navigator supports excluding items via Documentation navigatorExclude propPreview: documentation | landing | table |
invliD
approved these changes
Jun 12, 2018
themadcreator
approved these changes
Jun 12, 2018
| @@ -34,6 +45,9 @@ export class Navigator extends React.PureComponent<INavigatorProps> { | |||
| public componentDidMount() { | |||
| this.sections = []; | |||
| eachLayoutNode(this.props.items, (node, parents) => { | |||
| if (Utils.safeInvoke(this.props.itemExclude, node)) { | |||
There was a problem hiding this comment.
to be safe, we should make sure we handle the case this returns 'undefined' instead of 'false'
explicit check for safetyPreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocumentationnavigatorExcludeandNavigatoritemExcludeprops to support excluding items from the navigator results.can no longer navigate to "Components" page or "Overlays" section.