Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SVGPopover and SVGTooltip as they only set one prop #2601

Merged
merged 2 commits into from
Jun 15, 2018
Merged

remove SVGPopover and SVGTooltip as they only set one prop #2601

merged 2 commits into from
Jun 15, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jun 14, 2018 •
edited
Loading

so small, not worth maintaining

  • 🔥 remove SVGPopover and SVGTooltip components as they're trivial one-liners and were not even documented or exported. 
    - <SVGPopover content="..." target="..." />
+ <Popover targetElementTag="g" content="..." target="..." />

@blueprint-bot
Copy link

remove SVGPopover and SVGTooltip as they only set one prop

Preview: documentation | landing | table

@blueprint-bot
Copy link

missed one

Preview: documentation | landing | table

themadcreator
themadcreator approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill it with 🔥

@giladgray giladgray merged commit 7498c91 into develop Jun 15, 2018
@giladgray giladgray deleted the gg/no-svg-popover branch June 15, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

Assignees
No one assigned
Labels
Type: breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @themadcreator