upgrade documentalist, add "edit this page" links #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 19, 2018 17:17
themadcreator
approved these changes
Jun 20, 2018
| private renderPageActions(page: IPageData) { | ||
| return ( | ||
| <AnchorButton | ||
| href={`https://github.com/palantir/blueprint/blob/develop/${page.sourcePath}`} |
There was a problem hiding this comment.
probably worth extracting a const
| } | ||
| const version = this.props.useNextVersion && pkg.nextVersion ? pkg.nextVersion : pkg.version; | ||
| return ( | ||
| <a className={Classes.TEXT_MUTED} href={`https://www.npmjs.com/package/${pkg.name}`} target="_blank"> |
| @@ -100,3 +99,8 @@ export class NavHeader extends React.PureComponent<INavHeaderProps, {}> { | |||
| this.props.onToggleDark(!this.props.useDarkTheme); | |||
| }; | |||
| } | |||
|
|
|||
| /** Get major component of semver string. */ | |||
| await generateDocumentalistData(); | ||
| generateReleasesData(); | ||
| generateVersionsData(); | ||
| } catch (err) { |
There was a problem hiding this comment.
comment why console.log is better than console.error
| // one major version per release | ||
| const majors = new Map(); | ||
| for (version of value) { | ||
| const major = semver.major(version) |
There was a problem hiding this comment.
you just added that other function to extract this. should we consolidate to use one method or the other?
There was a problem hiding this comment.
this runs in node at build time, where we have the actual semver package. the other function runs at render time on the client where we don't have (or need) that external package.
added 2 commits
June 20, 2018 14:59
script commentPreview: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
Changes proposed in this pull request:
NpmPluginso there's only one docs data file (versions and releases now live inside docs.json)DocumentationrenderPageActionsprop to customize upper-right actions