Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spinner] Classes.LARGE/SMALL determine default size #2667

Merged
merged 4 commits into from
Jul 11, 2018
Merged

[Spinner] Classes.LARGE/SMALL determine default size #2667

merged 4 commits into from
Jul 11, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jul 10, 2018 •
edited
Loading

  • 👍 this actually un-breaks a 3.0 API break: <Spinner className={Classes.SMALL} /> now works as it used to!
  • remove the replacer from the upgrade script as it's no longer breaking

@giladgray giladgray mentioned this pull request Jul 10, 2018
Merged
@blueprint-bot
Copy link

remove replacer from upgrade script

Preview: documentation | landing | table

@blueprint-bot
Copy link

extends AbstractPureComponent

Preview: documentation | landing | table

@blueprint-bot
Copy link

Update spinner.md

Preview: documentation | landing | table

@giladgray giladgray merged commit c6c5bcd into develop Jul 11, 2018
@giladgray giladgray deleted the gg/spinner-classees branch July 11, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invliD invliD invliD approved these changes

@themadcreator themadcreator Awaiting requested review from themadcreator

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @invliD