[Checkbox] indicator is inline element #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 23, 2018 11:32
add disabled switch to xamplePreview: documentation | landing | table |
move some blocks aroundPreview: documentation | landing | table |
themadcreator
approved these changes
Jul 23, 2018
| margin: 0; | ||
| display: inline-block; | ||
| position: relative; | ||
| margin-top: -3px; |
There was a problem hiding this comment.
does this depend of font size?
There was a problem hiding this comment.
😕 it does, but checkboxes were not designed to support arbitrary font size. that would require a different approach. i've been fiddling with a flex layout a la menu items (requiring wrapping children in a <span>) but i don't think it's worth the change just yet.
| top: 0; | ||
| left: 0; | ||
| margin: 0; | ||
| display: inline-block; |
There was a problem hiding this comment.
this seems pretty major
There was a problem hiding this comment.
it is, but it's also wholly contained inside the component. no API has been changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@extendthat generated very bloated CSS.before
height: 16px. padding/position.
after
height: 18px (standard line-height). centered: perfect.
