Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] ensure active item is always enabled #2723

Merged
merged 2 commits into from
Jul 25, 2018
Merged

[select] ensure active item is always enabled #2723

merged 2 commits into from
Jul 25, 2018

Conversation

giladgray
Copy link
Contributor

Fixes #2634

Changes proposed in this pull request:

  • ensure QueryList always selects a valid item, especially when resetting.
  • much of this is setup for the next PR which will introduce un/controlled query & activeItem support to all components.

@giladgray giladgray changed the title [select] ensure valid initially selected item [select] ensure active item is always enabled Jul 24, 2018
@blueprint-bot
Copy link

fix tests

Preview: documentation | landing | table

@giladgray giladgray merged commit 8b3a929 into develop Jul 25, 2018
@giladgray giladgray deleted the gg/select-disabled-first branch July 25, 2018 18:28
@giladgray giladgray mentioned this pull request Aug 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

@invliD invliD Awaiting requested review from invliD

@jkillian jkillian Awaiting requested review from jkillian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @themadcreator