[Core] Button should render text if text={0} #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
suggested changes
Jul 26, 2018
| @@ -149,7 +149,7 @@ export abstract class AbstractButton<H extends React.HTMLAttributes<any>> extend | |||
| return [ | |||
| loading && <Spinner key="loading" className={Classes.BUTTON_SPINNER} size={Icon.SIZE_LARGE} />, | |||
| <Icon key="leftIcon" icon={icon} />, | |||
| (text || children) && ( | |||
| ((text != null && text !== "") || children) && ( | |||
There was a problem hiding this comment.
can you also make it children != null for the same reason?
This was referenced Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2703
Changes proposed in this pull request:
Instead of checking if the text prop is truthy, check if it is defined and not an empty string.
Reviewers should focus on:
I've added an extra check
(text != null && text !== "")to prevent a regression of the issue addressed in 540b88b.This regression was not picked up by the unit test here because the test in question is only checking if
children=""rather than testing thetextprop.I think another assertion should be added: