[ControlGroup] Add border-radius inheritance support to popovers #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@badams can you please fix the CircleCI build? I cannot accept a PR without a build. |
|
@giladgray sorted, forgot to setup CircleCi when I nuked my fork 😆 |
giladgray
suggested changes
Jul 30, 2018
| .#{$ns}-popover-wrapper, | ||
| .#{$ns}-popover-target { | ||
| border-radius: inherit; | ||
| } |
There was a problem hiding this comment.
please move this next to the border-radius styles around line 188. this location is smack in the middle of a whole bunch of z-index logic.
giladgray
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2730
Changes proposed in this pull request:
Adding
border-radius: inheritto the popover-target and popover-wrapper will pass it on to whatever component is wrapped (eg. button)Screenshot
Before:
After:
