[ControlGroup] Give border radius to :only-child #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@badams please fix the build. if you've configured it already then you might need to push new commits. |
giladgray
approved these changes
Jul 30, 2018
| @@ -189,6 +189,12 @@ Styleguide control-group | |||
| border-radius: 0 $pt-border-radius $pt-border-radius 0; | |||
| } | |||
|
|
|||
| // round all the corners of the only child element | |||
| > :only-child { | |||
There was a problem hiding this comment.
well color me 😱 i did not know this pseudoselector existed!
and it's always been there. https://developer.mozilla.org/en-US/docs/Web/CSS/:only-child
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a ControlGroup only has a single child component the :last-child border rules are applied.
Screenshot
Before:
After:
