[PanelStack] use IPanel in openPanel() public API #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanelView onClose/Open props skips getPanelProps() stepPreview: documentation | landing | table |
fix testsPreview: documentation | landing | table |
kadhirvelm
approved these changes
Jul 30, 2018
| safeInvoke(this.props.onClose, panel); | ||
| this.setState(state => ({ | ||
| direction: "pop", | ||
| stack: state.stack.filter(p => p !== panel), |
There was a problem hiding this comment.
Can we not slice(1) here again? If the panel is not at the top of the stack, it won't get here either way?
There was a problem hiding this comment.
it's not necessarily at the top inside this callback as it's async. the filter is ultimately the most robust check.
2 tasks
giladgray
pushed a commit
that referenced
this pull request
Jul 30, 2018
* Added panel stack * First test integrated * Tests added * Transitions adjusted * Updated readme * Made lower case * Dark theme added * Linting fixed * Review items fixed, transitions reverted * Removed extra panelClassName * _panel-stack.scss * minor docs * updated tests * Tests adjusted and fixed * [PanelStack] refactors & fix transitions (#2717) * fix the transitions! * example refactor: move stack to options bar * lint example * refactor header styles to use fewer classes * Classes.PANEL_STACK * fix tests * style fixes, simpler transition * no stack limit * back button nowrap * Adjusted transition to include opacity and -50% left movement * Removed useless type checking * Fixed opacity * Opacity * Opacity flipped * Removed 0 * Reversed opacities * One more attempt * [PanelStack] merge some files (#2719) * merge PanelHeader into PanelView * panelProps file with more docs * panelProps.ts * export panelProps, more docs * example key * docs * safeInvoke * changed easing settings * fix copyrights * onClose/Open param names * [PanelStack] use IPanel in openPanel() public API (#2738) * openPanel accepts IPanel instead of three args * PanelView onClose/Open props skips getPanelProps() step * fix tests * remove IPanelPptions * [PanelStack] documentation (#2737) * PanelStack docs * more docs refactors * adjust docs-modifiers margins * remove "pop the stack"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openPanelaccepts IPanel instead of three args.-this is more future-proof as we can update the one interface in non-breaking ways and see benefits everywhere, whereas changing the signature of the function would be breaking.
PanelViewonClose/Openprops cleans up thePanelStacklogiccc @kadhirvelm