Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] fix displayName for Blueprint3 #2741

Merged
merged 3 commits into from
Jul 31, 2018
Merged

[all] fix displayName for Blueprint3 #2741

merged 3 commits into from
Jul 31, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Jul 30, 2018 •
edited
Loading

  • new DISPLAYNAME_PREFIX constant in core props.ts
  • interpolated in every static displayName to ensure consistent prefix
    • caught a few missing displayNames
  • one place to update them all in the future!

@blueprint-bot
Copy link

fix a few

Preview: documentation | landing | table

@giladgray giladgray merged commit fb548d2 into develop Jul 31, 2018
@giladgray giladgray deleted the gg/displaynames branch October 14, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

@adidahiya adidahiya Awaiting requested review from adidahiya

Assignees
No one assigned
Labels
Type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @themadcreator