Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ControlGroup] fix HTMLSelect support #2744

Merged
merged 3 commits into from
Aug 1, 2018
Merged

[ControlGroup] fix HTMLSelect support #2744

merged 3 commits into from
Aug 1, 2018

Conversation

giladgray
Copy link
Contributor

Fixes #2743

Changes proposed in this pull request:

  • add new selector added in 3.0 to control-group scss
  • add more control types to ControlGroupExample
  • HTMLSelect <select> tag grows to fill parent (fixes fill bug I found in example)

@blueprint-bot
Copy link

blueprint-bot commented Jul 31, 2018 •
edited by giladgray
Loading

`<select>` grows to fill parent

Preview: documentation | landing | table

@giladgray giladgray merged commit 5175c10 into develop Aug 1, 2018
@giladgray giladgray deleted the gg/control-group-select branch August 1, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ControlGroup] ControlGroup doesn't support HTMLSelect components
3 participants
@giladgray @blueprint-bot @themadcreator