[table] Remove min width from editable components #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<EditableText>` has a default min-width of 80px, which overflows the table cell. Settings the minWidth prop to null will fix this.
giladgray
approved these changes
Dec 1, 2016
adidahiya
reviewed
Dec 1, 2016
| @@ -57,6 +57,7 @@ export class EditableCell extends React.Component<IEditableCellProps, {}> { | |||
| className={"bp-table-editable-name"} | |||
| defaultValue={value} | |||
| intent={intent} | |||
| minWidth={null} | |||
There was a problem hiding this comment.
shouldn't we limit it to something, like 5px maybe? also, minor: it always feels weird to pass null as a prop.
There was a problem hiding this comment.
The min/max is set by the table's minColumnWidth/maxColumnWidth and is handled elsewhere. We don't want them to compete. I don't know how to unset a default other than passing null
There was a problem hiding this comment.
gotcha, that makes sense; could be worth a code comment describing how these two things affect each other at a distance
Merged
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
`<EditableText>` has a default min-width of 80px, which overflows the table cell. Settings the minWidth prop to null will fix this.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281
Changes proposed in this pull request:
<EditableText>has a default min-width of 80px,which overflows the table cell.
Settings the minWidth prop to null will fix this.